Re: [PATCH RESEND v6 2/2] scripts: checkpatch: check unused parameters for function-like macro

[Joe Perches]

On Mon, 2024-05-06 at 13:46 +1200, Barry Song wrote:
> From: Xining Xu <mac.xxn@xxxxxxxxxxx>
> 
> If function-like macros do not utilize a parameter, it might result in a
> build warning.  In our coding style guidelines, we advocate for utilizing
> static inline functions to replace such macros.  This patch verifies
> compliance with the new rule.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -6040,6 +6040,12 @@ sub process {
>  					CHK("MACRO_ARG_PRECEDENCE",
>  					    "Macro argument '$arg' may be better as '($arg)' to avoid precedence issues\n" . "$herectx");
>  				}
> +
> +# check if this is an unused argument
> +				if ($define_stmt !~ /\b$arg\b/) {
> +					WARN("MACRO_ARG_UNUSED",
> +						"Argument '$arg' is not used in function-like macro\n" . "$herectx");

trivia:  This should be aligned to the open parenthesis.

Otherwise:
Acked-by: Joe Perches <joe@xxxxxxxxxxx>