RE: [PATCH v3] selftests/vDSO: Explicit unsigned char conversion for elf_hash

From: David Laight
Date: Sun May 05 2024 - 09:21:19 EST


From: Justin Stitt
> Sent: 01 May 2024 20:55
..
> > static unsigned long elf_hash(const unsigned char *name)
..
> Is it possible to just change the types of the parameters of vdso_sym()
> or does that trigger even more warnings on the callsites of vdso_sym()?

Isn't the problem the definition of elf_hash()?
A '\0' terminated string really ought to be 'char *' not 'unsigned char *'.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)