Re: [PATCH 3/3] RDMA/hfi1: Use RMW accessors for changing LNKCTL2

From: Leon Romanovsky
Date: Sun May 05 2024 - 09:09:58 EST


On Fri, May 03, 2024 at 10:04:16AM -0300, Jason Gunthorpe wrote:
> On Fri, May 03, 2024 at 01:18:35PM +0300, Ilpo Järvinen wrote:
> > On Thu, 15 Feb 2024, Ilpo Järvinen wrote:
> >
> > > Convert open coded RMW accesses for LNKCTL2 to use
> > > pcie_capability_clear_and_set_word() which makes its easier to
> > > understand what the code tries to do.
> > >
> > > LNKCTL2 is not really owned by any driver because it is a collection of
> > > control bits that PCI core might need to touch. RMW accessors already
> > > have support for proper locking for a selected set of registers
> > > (LNKCTL2 is not yet among them but likely will be in the future) to
> > > avoid losing concurrent updates.
> > >
> > > Suggested-by: Lukas Wunner <lukas@xxxxxxxxx>
> > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> > > Reviewed-by: Dean Luick <dean.luick@xxxxxxxxxxxxxxxxxxxx>
> >
> > I found out from Linux RDMA and InfiniBand patchwork that this patch had
> > been silently closed as "Not Applicable". Is there some reason for
> > that?
>
> It is part of a series that crosses subsystems, series like that
> usually go through some other trees.

Exactly, this is why I marked it as "Not Applicable".

>
> If you want single patches applied then please send single
> patches.. It is hard to understand intent from mixed series.
>
> Jason