Re: [PATCH v5 1/2] lib/test_bitops: Add benchmark test for fns()

From: Miguel Ojeda
Date: Sun May 05 2024 - 06:44:22 EST


On Sat, May 4, 2024 at 12:23 AM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
>
> Adding Miguel as compiler attributes maintainer to make him aware of the
> change. I think it would be reasonable to have you take it through the
> bitops tree with your ack so that the test patch can make use of this as
> the fix for the robot's issue.

Thanks Nathan!

Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>

The new macro sounds OK to me. Perhaps we should add some docs to the
other two attributes about their relationship and/or the existence of
this new `__always_used` one (so that it is easier to find). And if
so, then perhaps the docs for `__always_used` can be simplified.

> One gotcha that might be worth mentioning is that this combination only
> works on functions and non-local variables (i.e., static or global).

Yeah, since the `unused` one only applies to that, right?

Cheers,
Miguel