Re: [PATCH v2] psi: Fix avg trigger being fired unexpectedly.

From: Markus Elfring
Date: Sat May 04 2024 - 08:34:52 EST



> But, for PSI_AVGS, win->value should be initialized with group->total[PSI_AVGS].
> Moreover, to get exact initial value for win->value, it should be set
> under each trigger lock to avoid concurrent changes to group->total[].

> kernel/sched/psi.c | 8 +++++---


* Can imperative wordings be desirable for such a change description?

* Is there a need to perform proposed adjustments as separate update steps?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n81

* Would you like to add the tag “Fixes” accordingly?


Regards,
Markus