Re: [PATCH v4 1/3] PCI: qcom: Refactor common code
From: kernel test robot
Date: Sat May 04 2024 - 01:31:34 EST
Hi Shashank,
kernel test robot noticed the following build warnings:
[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.9-rc6 next-20240503]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shashank-Babu-Chinta-Venkata/PCI-qcom-Refactor-common-code/20240502-003801
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20240501163610.8900-2-quic_schintav%40quicinc.com
patch subject: [PATCH v4 1/3] PCI: qcom: Refactor common code
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240504/202405041326.aSnZgClv-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240504/202405041326.aSnZgClv-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405041326.aSnZgClv-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/pci/controller/dwc/pcie-qcom-common.c: In function 'qcom_pcie_common_icc_get_resource':
>> drivers/pci/controller/dwc/pcie-qcom-common.c:25:24: warning: returning 'long int' from a function with return type 'struct icc_path *' makes pointer from integer without a cast [-Wint-conversion]
25 | return PTR_ERR(icc_mem_p);
| ^~~~~~~~~~~~~~~~~~
vim +25 drivers/pci/controller/dwc/pcie-qcom-common.c
15
16 #define QCOM_PCIE_LINK_SPEED_TO_BW(speed) \
17 Mbps_to_icc(PCIE_SPEED2MBS_ENC(pcie_link_speed[speed]))
18
19 struct icc_path *qcom_pcie_common_icc_get_resource(struct dw_pcie *pci, const char *path)
20 {
21 struct icc_path *icc_mem_p;
22
23 icc_mem_p = devm_of_icc_get(pci->dev, path);
24 if (IS_ERR_OR_NULL(icc_mem_p))
> 25 return PTR_ERR(icc_mem_p);
26 return icc_mem_p;
27 }
28 EXPORT_SYMBOL_GPL(qcom_pcie_common_icc_get_resource);
29
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki