Re: [PATCH v2 3/3] net: phy: bcm-phy-lib: Implement BroadR-Reach link modes

From: kernel test robot
Date: Fri May 03 2024 - 20:06:21 EST


Hi Kamil,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]
[also build test WARNING on net-next/main linus/master v6.9-rc6 next-20240503]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Kamil-Hor-k-2N/net-phy-bcm54811-New-link-mode-for-BroadR-Reach/20240503-164308
base: net/main
patch link: https://lore.kernel.org/r/20240503083719.899312-4-kamilh%40axis.com
patch subject: [PATCH v2 3/3] net: phy: bcm-phy-lib: Implement BroadR-Reach link modes
config: powerpc-randconfig-r081-20240504 (https://download.01.org/0day-ci/archive/20240504/202405040748.9mCHwtzA-lkp@xxxxxxxxx/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 37ae4ad0eef338776c7e2cffb3896153d43dcd90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240504/202405040748.9mCHwtzA-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405040748.9mCHwtzA-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

In file included from drivers/net/phy/broadcom.c:13:
In file included from drivers/net/phy/bcm-phy-lib.h:9:
In file included from include/linux/brcmphy.h:5:
In file included from include/linux/phy.h:16:
In file included from include/linux/ethtool.h:18:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:8:
In file included from include/linux/cacheflush.h:5:
In file included from arch/powerpc/include/asm/cacheflush.h:7:
In file included from include/linux/mm.h:2210:
include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/net/phy/broadcom.c:619:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
619 | if (of_property_read_bool(np, "enet-phy-lane-swap")) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/phy/broadcom.c:627:9: note: uninitialized use occurs here
627 | return ret;
| ^~~
drivers/net/phy/broadcom.c:619:2: note: remove the 'if' if its condition is always true
619 | if (of_property_read_bool(np, "enet-phy-lane-swap")) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/phy/broadcom.c:614:9: note: initialize the variable 'ret' to silence this warning
614 | int ret;
| ^
| = 0
2 warnings generated.


vim +619 drivers/net/phy/broadcom.c

b0ed0bbfb3046e Kevin Lo 2020-05-16 610
f1e9c8e593d6ea Kamil Horák - 2N 2024-05-03 611 static int bcm5481x_config_delay_swap(struct phy_device *phydev)
57bb7e222804c6 Anton Vorontsov 2008-03-04 612 {
b14995ac2527b4 Jon Mason 2016-11-04 613 struct device_node *np = phydev->mdio.dev.of_node;
57bb7e222804c6 Anton Vorontsov 2008-03-04 614 int ret;
57bb7e222804c6 Anton Vorontsov 2008-03-04 615
f1e9c8e593d6ea Kamil Horák - 2N 2024-05-03 616 /* Set up the delay. */
042cb56478152b Tao Ren 2018-11-05 617 bcm54xx_config_clock_delay(phydev);
57bb7e222804c6 Anton Vorontsov 2008-03-04 618
b14995ac2527b4 Jon Mason 2016-11-04 @619 if (of_property_read_bool(np, "enet-phy-lane-swap")) {
b14995ac2527b4 Jon Mason 2016-11-04 620 /* Lane Swap - Undocumented register...magic! */
b14995ac2527b4 Jon Mason 2016-11-04 621 ret = bcm_phy_write_exp(phydev, MII_BCM54XX_EXP_SEL_ER + 0x9,
b14995ac2527b4 Jon Mason 2016-11-04 622 0x11B);
b14995ac2527b4 Jon Mason 2016-11-04 623 if (ret < 0)
b14995ac2527b4 Jon Mason 2016-11-04 624 return ret;
b14995ac2527b4 Jon Mason 2016-11-04 625 }
b14995ac2527b4 Jon Mason 2016-11-04 626
57bb7e222804c6 Anton Vorontsov 2008-03-04 627 return ret;
57bb7e222804c6 Anton Vorontsov 2008-03-04 628 }
57bb7e222804c6 Anton Vorontsov 2008-03-04 629

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki