RE: [PATCH 00/21] pinctrl: Use scope based of_node_put() cleanups

From: Peng Fan
Date: Fri May 03 2024 - 19:11:58 EST


Hi Linus,

> Subject: Re: [PATCH 00/21] pinctrl: Use scope based of_node_put() cleanups
>
> Hi Peng,
>
> thanks for doing this! I am very much in favor of using scoped management
> of resources where it makes it easier to do the right thing.
>
> I agree with Krzysztof's comment that we should avoid scoping in cases where
> there is a clear path grab/use/release so the code is easy to read already as it
> is. Let's drop those.
Yeah, will drop them in v2.

>
> I saw there was some patch that was even a fix, perhaps I should pick that
> one separately for fixes, but probably it is non-urgent.

Not urgent, I will add fix tag in v2.

Thanks,
Peng.
>
> I suppose we will just apply v2 after people had some time to look at it!
>
> Yours,
> Linus Walleij