Re: [PATCH] drm/msm/gen_header: allow skipping the validation

From: Dmitry Baryshkov
Date: Fri May 03 2024 - 16:58:40 EST


On Fri, May 03, 2024 at 09:48:12AM -0700, Nathan Chancellor wrote:
> Hi Dmitry,
>
> On Tue, Apr 09, 2024 at 05:22:54PM +0300, Dmitry Baryshkov wrote:
> > We don't need to run the validation of the XML files if we are just
> > compiling the kernel. Skip the validation unless the user enables
> > corresponding Kconfig option. This removes a warning from gen_header.py
> > about lxml being not installed.
> >
> > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > Closes: https://lore.kernel.org/all/20240409120108.2303d0bd@xxxxxxxxxxxxxxxx/
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> > drivers/gpu/drm/msm/Kconfig | 8 ++++++++
> > drivers/gpu/drm/msm/Makefile | 9 ++++++++-
> > drivers/gpu/drm/msm/registers/gen_header.py | 14 +++++++++++---
> > 3 files changed, 27 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> > index f202f26adab2..4c9bf237d4a2 100644
> > --- a/drivers/gpu/drm/msm/Kconfig
> > +++ b/drivers/gpu/drm/msm/Kconfig
> > @@ -54,6 +54,14 @@ config DRM_MSM_GPU_SUDO
> > Only use this if you are a driver developer. This should *not*
> > be enabled for production kernels. If unsure, say N.
> >
> > +config DRM_MSM_VALIDATE_XML
> > + bool "Validate XML register files against schema"
> > + depends on DRM_MSM && EXPERT
> > + depends on $(success,$(PYTHON3) -c "import lxml")
> > + help
> > + Validate XML files with register definitions against rules-fd schema.
> > + This option is mostly targeting DRM MSM developers. If unsure, say N.
>
> Is this change going to be applied? I have gotten a little tired of
> seeing "lxml not found, skipping validation" in all of my builds :)
>
I've posted v2, including CI changes. The plan is to get it merged
before the drm/msm pull request.

--
With best wishes
Dmitry