Re: [PATCH v2 1/2] drm/msm/gen_header: allow skipping the validation

From: Abhinav Kumar
Date: Fri May 03 2024 - 15:33:24 EST




On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote:
We don't need to run the validation of the XML files if we are just
compiling the kernel. Skip the validation unless the user enables
corresponding Kconfig option. This removes a warning from gen_header.py
about lxml being not installed.

Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Closes: https://lore.kernel.org/all/20240409120108.2303d0bd@xxxxxxxxxxxxxxxx/
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
drivers/gpu/drm/msm/Kconfig | 8 ++++++++
drivers/gpu/drm/msm/Makefile | 9 ++++++++-
drivers/gpu/drm/msm/registers/gen_header.py | 14 +++++++++++---
3 files changed, 27 insertions(+), 4 deletions(-)


Looks reasonable to me, only developers need to worry about or fix the xml files

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>