Re: [PATCH] selftests/resctrl: fix clang build failure: use LOCAL_HDRS

From: Shuah Khan
Date: Fri May 03 2024 - 15:27:11 EST


On 5/3/24 12:39, Reinette Chatre wrote:


On 5/2/2024 7:17 PM, John Hubbard wrote:
First of all, in order to build with clang at all, one must first apply
Valentin Obst's build fix for LLVM [1]. Once that is done, then when
building with clang, via:

make LLVM=1 -C tools/testing/selftests

...the following error occurs:

clang: error: cannot specify -o when generating multiple output files

This is because clang, unlike gcc, won't accept invocations of this
form:

clang file1.c header2.h

Fix this by using selftests/lib.mk facilities for tracking local header
file dependencies: add them to LOCAL_HDRS, leaving only the .c files to
be passed to the compiler.

[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@xxxxxxxxxxxxxxx/

Fixes: 8e289f454289 ("selftests/resctrl: Add resctrl.h into build deps")
Cc: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
---

Thank you.

Acked-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reinette


Thank you. Applied to linux-kselftest next for Linux 6.10-rc1

thanks,
-- Shuah