RE: [PATCH v2 1/2] e1000e: let the sleep codes run every time

From: Keller, Jacob E
Date: Fri May 03 2024 - 14:19:38 EST




> -----Original Message-----
> From: Ricky Wu <en-wei.wu@xxxxxxxxxxxxx>
> Sent: Friday, May 3, 2024 3:18 AM
> To: Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; intel-wired-
> lan@xxxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; rickywu0421@xxxxxxxxx; en-wei.wu@xxxxxxxxxxxxx
> Subject: [PATCH v2 1/2] e1000e: let the sleep codes run every time
>
> Originally, the sleep codes being moved forward only
> ran if we met some conditions (e.g. BMSR_LSTATUS bit
> not set in phy_status). Moving these sleep codes forward
> makes the usec_interval take effect every time.
>
> Signed-off-by: Ricky Wu <en-wei.wu@xxxxxxxxxxxxx>

What's the goal here? Do we need to sleep before initially checking the state?