Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis

From: Ashok Kumar
Date: Fri May 03 2024 - 13:01:51 EST



On Thursday, May 2, 2024 at 11:54:58 PM PDT, Julia Lawall <julia.lawall@xxxxxxxx> wrote:







On Thu, 2 May 2024, Ashok Kumar wrote:

> Corrected coding style CHECK: Alignment should match open parenthesis

Ashok, I think the code is nicer as is, because it has all the constant
numbers lined up.

julia

Thanks for the update I will ignore this change. 

Is there a list of exceptions to the checkpatch information that we can ignore in general.


>
> Signed-off-by: Ashok Kumar <ashokemailat@xxxxxxxxx>
> ---
>  drivers/staging/fbtft/fb_tinylcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index 9469248f2c50..60cda57bcb33 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
>      write_reg(par, 0xE5, 0x00);
>      write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
>      write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> -              0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> +          0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
>      write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
>      write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
>      udelay(250);
> --
> 2.34.1
>
>
>