Re: [PATCH 2/5] x86/virt/tdx: Move TDMR metadata fields map table to local variable

From: Dave Hansen
Date: Fri May 03 2024 - 12:02:00 EST


On 3/1/24 03:20, Kai Huang wrote:
> The kernel reads all TDMR related global metadata fields based on a
> table which maps the metadata fields to the corresponding members of
> 'struct tdx_tdmr_sysinfo'.
>
> Currently this table is a static variable. But this table is only used
> by the function which reads these metadata fields and becomes useless
> after reading is done.

Is this intended to be a problem statement? _How_ is this a problem?

> Change the table to function local variable. This also saves the
> storage of the table from the kernel image.

I'm confused how this would happen. Could you please explain your logic
a bit here?