Re: [PATCH v2 1/2] arm64/arch_timer: include <linux/percpu.h>

From: Mark Rutland
Date: Fri May 03 2024 - 11:14:51 EST


On Thu, May 02, 2024 at 12:34:48PM +0000, Puranjay Mohan wrote:
> arch_timer.h includes linux/smp.h to use DEFINE_PER_CPU() and it works
> because smp.h includes percpu.h. The next commit will remove percpu.h
> from smp.h and it will break this usage.
>
> Explicitly include percpu.h and remove smp.h
>
> Signed-off-by: Puranjay Mohan <puranjay@xxxxxxxxxx>

Looks like this was a thinko in commit:

6acc71ccac7187fc ("arm64: arch_timer: Allows a CPU-specific erratum to only affect a subset of CPUs")

.. which, as you say, should have included <linux/percpu.h> rather than
<linux/smp.h>.

This is a cleanup regardless of the next patch.

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Mark.

> ---
> arch/arm64/include/asm/arch_timer.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/arch_timer.h b/arch/arm64/include/asm/arch_timer.h
> index 934c658ee947..f5794d50f51d 100644
> --- a/arch/arm64/include/asm/arch_timer.h
> +++ b/arch/arm64/include/asm/arch_timer.h
> @@ -15,7 +15,7 @@
> #include <linux/bug.h>
> #include <linux/init.h>
> #include <linux/jump_label.h>
> -#include <linux/smp.h>
> +#include <linux/percpu.h>
> #include <linux/types.h>
>
> #include <clocksource/arm_arch_timer.h>
> --
> 2.40.1
>