Re: [PATCH net v2 1/2] ax25: change kfree in ax25_dev_free to ax25_dev_free
From: Dan Carpenter
Date: Fri May 03 2024 - 07:33:42 EST
On Fri, May 03, 2024 at 07:36:54AM +0200, Markus Elfring wrote:
> > The ax25_dev is managed by reference counting, so it should not be
> > deallocated directly by kfree() in ax25_dev_free(), replace it with
> > ax25_dev_put() instead.
>
> You repeated a wording mistake in the summary phrase from a previous cover letter.
Yeah. That's true. The subject should be changed to:
Subject: [PATCH] ax25: change kfree() in ax25_dev_free() to ax25_dev_put()
Another option would be:
Subject: [PATCH] ax25: use ax25_dev_put() in ax25_dev_free()
Otherwise the commit message is okay as-is.
regards,
dan carpenter