Re: [PATCH v9 1/3] soc: qcom: Add qcom_rproc_minidump module

[Mukesh Ojha]

On 4/30/2024 7:08 PM, Bjorn Andersson wrote:
> On Tue, Mar 26, 2024 at 07:43:12PM +0530, Mukesh Ojha wrote:
> > Add qcom_rproc_minidump module in a preparation to remove
> > minidump specific code from driver/remoteproc/qcom_common.c
> > and provide needed exported API, this as well helps to
> > abstract minidump specific data layout from qualcomm's
> > remoteproc driver.
> >
> > It is just a copying of qcom_minidump() functionality from
> > driver/remoteproc/qcom_common.c into a separate file under
> > qcom_rproc_minidump().
>
> I'd prefer to see this enter the git history as one patch, extracting
> this logic from the remoteproc into its own driver - rather than as
> presented here give a sense that it's a new thing added. (I'll take care
> of the maintainer sync...)
>
> I also would prefer for this to include a problem description,
> documenting why this is done.
>
>
> I've not compared patch 1 and 3, but I'd also like a statement in the
> commit message telling if there are any changes, or if the functions are
> cleanly moved from one place to another.


Thanks for the review, addressed the comments here in v10.

https://lore.kernel.org/lkml/1714724287-12518-1-git-send-email-quic_mojha@xxxxxxxxxxx/

-Mukesh