Re: [PATCH v4 1/2] dt-bindings: hwmon: Add Sophgo SG2042 external hardware monitor support

From: Krzysztof Kozlowski
Date: Fri May 03 2024 - 03:09:43 EST


On 03/05/2024 04:20, Inochi Amaoto wrote:
> Due to the design, Sophgo SG2042 use an external MCU to provide
> hardware information, thermal information and reset control.
>
> Add bindings for this monitor device.

> +
> +required:
> + - compatible
> + - reg
> + - "#thermal-sensor-cells"
> +
> +allOf:
> + - $ref: ../thermal/thermal-sensor.yaml#

Where did you find such path? Please use full path instead, so
/schemas/thermal.....

> +
> +additionalProperties: false

unevaluatedProperties: false instead (even though currently it does not
matter).


Best regards,
Krzysztof