Re: [PATCH 1/3] spi: spi-microchip-core: Add support for GPIO based CS
From: kernel test robot
Date: Fri May 03 2024 - 01:28:28 EST
Hi Prajna,
kernel test robot noticed the following build warnings:
[auto build test WARNING on broonie-spi/for-next]
[also build test WARNING on robh/for-next krzk-dt/for-next linus/master v6.9-rc6 next-20240502]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Prajna-Rajendra-Kumar/spi-spi-microchip-core-Add-support-for-GPIO-based-CS/20240502-223714
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link: https://lore.kernel.org/r/20240502143410.12629-2-prajna.rajendrakumar%40microchip.com
patch subject: [PATCH 1/3] spi: spi-microchip-core: Add support for GPIO based CS
config: arm-randconfig-002-20240503 (https://download.01.org/0day-ci/archive/20240503/202405031328.ljBB1tMb-lkp@xxxxxxxxx/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 37ae4ad0eef338776c7e2cffb3896153d43dcd90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240503/202405031328.ljBB1tMb-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405031328.ljBB1tMb-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
In file included from drivers/spi/spi-microchip-core.c:21:
In file included from include/linux/spi/spi.h:17:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:2208:
include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/spi/spi-microchip-core.c:261:11: warning: address of array 'spi->cs_gpiod' will always evaluate to 'true' [-Wpointer-bool-conversion]
261 | if (spi->cs_gpiod)
| ~~ ~~~~~^~~~~~~~
2 warnings generated.
vim +261 drivers/spi/spi-microchip-core.c
255
256 static int mchp_corespi_setup(struct spi_device *spi)
257 {
258 struct mchp_corespi *corespi = spi_controller_get_devdata(spi->controller);
259 u32 reg;
260
> 261 if (spi->cs_gpiod)
262 return 0;
263
264 /*
265 * Active high targets need to be specifically set to their inactive
266 * states during probe by adding them to the "control group" & thus
267 * driving their select line low.
268 */
269 if (spi->mode & SPI_CS_HIGH) {
270 reg = mchp_corespi_read(corespi, REG_SLAVE_SELECT);
271 reg |= BIT(spi_get_chipselect(spi, 0));
272 mchp_corespi_write(corespi, REG_SLAVE_SELECT, reg);
273 }
274 return 0;
275 }
276
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki