Re: [PATCH v2 1/1] selftests: cgroup: remove redundant addition of memory controller

[Yosry Ahmed]

On Thu, May 2, 2024 at 1:05 PM Usama Arif <usamaarif642@xxxxxxxxx> wrote:
>
> Memory controller is already added in main which invokes
> the test, hence this does not need to be done in test_no_kmem_bypass.

nit: The memory controller is "enabled", not added. Same for the subject line.

>
> Signed-off-by: Usama Arif <usamaarif642@xxxxxxxxx>

Acked-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx>

> ---
>  tools/testing/selftests/cgroup/test_zswap.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c
> index cd864ab825d0..19ac29c533e0 100644
> --- a/tools/testing/selftests/cgroup/test_zswap.c
> +++ b/tools/testing/selftests/cgroup/test_zswap.c
> @@ -485,8 +485,6 @@ static int test_no_kmem_bypass(const char *root)
>         trigger_allocation_size = sys_info.totalram / 20;
>
>         /* Set up test memcg */
> -       if (cg_write(root, "cgroup.subtree_control", "+memory"))
> -               goto out;
>         test_group = cg_name(root, "kmem_bypass_test");
>         if (!test_group)
>                 goto out;
> --
> 2.43.0
>