Re: [PATCH v2] x86/split_lock: fix delayed detection enabling
From: kernel test robot
Date: Thu May 02 2024 - 20:29:22 EST
Hi Maksim,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tip/x86/core]
[also build test WARNING on tip/master linus/master v6.9-rc6 next-20240502]
[cannot apply to tip/auto-latest]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Maksim-Davydov/x86-split_lock-fix-delayed-detection-enabling/20240502-183110
base: tip/x86/core
patch link: https://lore.kernel.org/r/20240502102731.84429-1-davydov-max%40yandex-team.ru
patch subject: [PATCH v2] x86/split_lock: fix delayed detection enabling
config: i386-buildonly-randconfig-005-20240503 (https://download.01.org/0day-ci/archive/20240503/202405030838.XyIfnymG-lkp@xxxxxxxxx/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240503/202405030838.XyIfnymG-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405030838.XyIfnymG-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> arch/x86/kernel/cpu/intel.c:1113:13: warning: '__split_lock_reenable' defined but not used [-Wunused-function]
1113 | static void __split_lock_reenable(struct work_struct *work)
| ^~~~~~~~~~~~~~~~~~~~~
vim +/__split_lock_reenable +1113 arch/x86/kernel/cpu/intel.c
727209376f4998 Guilherme G. Piccoli 2022-10-24 1112
727209376f4998 Guilherme G. Piccoli 2022-10-24 @1113 static void __split_lock_reenable(struct work_struct *work)
727209376f4998 Guilherme G. Piccoli 2022-10-24 1114 {
727209376f4998 Guilherme G. Piccoli 2022-10-24 1115 sld_update_msr(true);
727209376f4998 Guilherme G. Piccoli 2022-10-24 1116 }
73f2dbc05507dd Maksim Davydov 2024-05-02 1117 /*
73f2dbc05507dd Maksim Davydov 2024-05-02 1118 * In order for each CPU to schedule itself delayed work independently of the
73f2dbc05507dd Maksim Davydov 2024-05-02 1119 * others, delayed work struct should be per-CPU. This is not required when
73f2dbc05507dd Maksim Davydov 2024-05-02 1120 * sysctl_sld_mitigate is enabled because of the semaphore, that limits
73f2dbc05507dd Maksim Davydov 2024-05-02 1121 * the number of simultaneously scheduled delayed works to 1.
73f2dbc05507dd Maksim Davydov 2024-05-02 1122 */
73f2dbc05507dd Maksim Davydov 2024-05-02 1123 static DEFINE_PER_CPU(struct delayed_work, sl_reenable);
73f2dbc05507dd Maksim Davydov 2024-05-02 1124
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki