Re: [PATCH] spmi: pmic-arb: Fix of_irq_get_byname() error checking

From: Stephen Boyd
Date: Thu May 02 2024 - 18:24:44 EST


Quoting Dan Carpenter (2024-05-02 00:08:29)
> On Wed, May 01, 2024 at 05:55:03PM -0700, Stephen Boyd wrote:
> > Quoting Dan Carpenter (2024-04-24 04:42:46)
> > > There are two bugs in this code:
> > > 1) The "irq" variable needs to be signed for the error handling to
> > > work.
> > > 2) The of_irq_get_byname() also returns zero on error so change the
> > > comparison from < 0 to <= 0.
> > >
> > > Fixes: 932282f154ac ("spmi: pmic-arb: Register controller for bus instead of arbiter")
> >
> > Sadly this isn't stable because I just send patches over email.
> >
>
> If you're going to send these as email then you should fold it into the
> original commit or otherwise people will be confused.

I removed the fixes tag. I will fold it in with your SoB, thanks!