Re: [PATCH v2] tools/build: Add clang cross-compilation flags to feature detection

[Björn Töpel]

Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx> writes:

> On Fri, Apr 26, 2024 at 12:31:17PM +0200, Björn Töpel wrote:
>> Jiri Olsa <olsajiri@xxxxxxxxx> writes:
>> 
>> > On Thu, Nov 02, 2023 at 11:32:52AM +0100, Björn Töpel wrote:
>> >> From: Björn Töpel <bjorn@xxxxxxxxxxxx>
>> >> 
>> >> When a tool cross-build has LLVM=1 set, the clang cross-compilation
>> >> flags are not passed to the feature detection build system. This
>> >> results in the host's features are detected instead of the targets.
>> >> 
>> >> E.g, triggering a cross-build of bpftool:
>> >> 
>> >>   cd tools/bpf/bpftool
>> >>   make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- LLVM=1
>> >> 
>> >> would report the host's, and not the target's features.
>> >> 
>> >> Correct the issue by passing the CLANG_CROSS_FLAGS variable to the
>> >> feature detection makefile.
>> >> 
>> >> Fixes: cebdb7374577 ("tools: Help cross-building with clang")
>> >> Signed-off-by: Björn Töpel <bjorn@xxxxxxxxxxxx>
>> >
>> > Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
>> 
>> Waking up the dead!
>> 
>> Arnaldo, Jean-Philippe: I'm still stung by what this patch fixes. LMK
>> what you need from me/this patch to pick it up.
>
> I guess the problem is these files don't have a specific tree. Since you
> mention BPF maybe it should go through the BPF tree, in which case you
> could resend to the tools/bpf maintainers (and "PATCH bpf" subject prefix)
>
> FWIW the change looks good to me:
>
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>

Thanks for the review. Yes, maybe it's a orphan files issue! It does
seem a bit weird to route it via BPF, since it's just a regular
cross-build fix -- Not directly related to BPF. Regardless; I'll do a
respin targetted at *some* tree. ;-)


Björn