Re: [PATCH 02/10] x86/insn: Fix PUSH instruction in x86 instruction decoder opcode map

From: Adrian Hunter
Date: Thu May 02 2024 - 15:11:39 EST


On 2/05/24 16:41, Arnaldo Carvalho de Melo wrote:
> On Thu, May 02, 2024 at 01:58:45PM +0300, Adrian Hunter wrote:
>> The x86 instruction decoder is used not only for decoding kernel
>> instructions. It is also used by perf uprobes (user space probes) and by
>> perf tools Intel Processor Trace decoding. Consequently, it needs to
>> support instructions executed by user space also.
>
> I wonder if we should do it this way, i.e. updating both tools/ and
> kernel source code in the same patch.
>
> I think the best is to update the kernel bits, then, after that is
> merged, do the tooling part.

For objtool purposes, it might be better to do both at the same time.

>
> To avoid possible, yet unlikely, clashes in linux-next, for instance.

Always gonna find out about clashes at some point.