Re: [PATCH 2/3] spi: dt-bindings: Add num-cs property for mpfs-spi

From: Krzysztof Kozlowski
Date: Thu May 02 2024 - 10:53:51 EST


On 02/05/2024 16:34, Prajna Rajendra Kumar wrote:
> The PolarFire SoC SPI controller supports multiple chip selects,but in
> the MSS, only one CS line is physically wired. To reflect this hardware
> limitation in the device tree, the binding enforces that the 'num-cs'
> property defaults to 1 and cannot exceed 1 unless additional
> chip select lines are explicitly defined using GPIO descriptors.
>

You marked it as Fix for bug, but I don't understand where the bug is.
Do you describe above the issue or the solution?

> + - if:
> + properties:
> + compatible:
> + contains:
> + const: microchip,mpfs-spi
> + not:
> + required:
> + - cs-gpios

I don't understand what you are expressing here. Did you actually
validate it that it achieves exactly what you want?

> + then:
> + properties:
> + num-cs:
> + default: 1
> + maximum: 1
> +
> unevaluatedProperties: false
>
> examples:

Best regards,
Krzysztof