Re: [PATCH 1/2] dt-bindings: drm/bridge: anx7625: Add a perporty to change TDM setting

From: Conor Dooley
Date: Thu May 02 2024 - 10:50:28 EST


On Thu, May 02, 2024 at 09:03:31AM +0000, Hsin-Te Yuan wrote:
> Add a perporty to indicate whether anx7625 should shift the first audio
> data bit. The default TDM setting is to shift the first audio data bit.
>
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@xxxxxxxxxxxx>
> ---
> .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index a1ed1004651b9..915d5d54a2160 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -82,6 +82,10 @@ properties:
> type: boolean
> description: let the driver enable audio HDMI codec function or not.
>
> + no-shift-audio-data:
> + type: boolean
> + description: Disable the first audio data bit shift in the TDM settings.

This just looks like software policy, since there's no mention in the
commit message or description as to what property of the hardware causes
this to be required. Can you please explain why this property is needed?

You're also missing a vendor prefix.

Thanks,
Conor.

> +
> aux-bus:
> $ref: /schemas/display/dp-aux-bus.yaml#
>
>
> --
> 2.45.0.rc1.225.g2a3ae87e7f-goog
>

Attachment: signature.asc
Description: PGP signature