Re: [PATCH v2 1/2] spi: spi-cadence: Add optional reset control support

From: Krzysztof Kozlowski
Date: Thu May 02 2024 - 10:16:54 EST


On 02/05/2024 12:47, Ji Sheng Teoh wrote:
>
> /* Macros for the SPI controller read/write */
> @@ -588,6 +591,16 @@ static int cdns_spi_probe(struct platform_device *pdev)
> goto remove_ctlr;
> }
>
> + xspi->rstc = devm_reset_control_get_optional_exclusive(&pdev->dev, "spi");
> + if (IS_ERR(xspi->rstc)) {
> + ret = PTR_ERR(xspi->rstc);
> + dev_err(&pdev->dev, "Cannot get SPI reset.\n");

Please switch to:
ret = dev_err_probe()

Best regards,
Krzysztof