Re: [PATCH 2/2] staging: pi433: Rename goto label.

[Shahar Avidar]

On 01/05/2024 17:06, Dan Carpenter wrote:
> On Wed, May 01, 2024 at 08:58:20AM +0300, Shahar Avidar wrote:
> > Use destroy_class_and_remove_dbfs instead of unreg_class_and_remove_dbfs.
> >
> > Signed-off-by: Shahar Avidar <ikobh7@xxxxxxxxx>
> > ---
> >   drivers/staging/pi433/pi433_if.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> > index c8c1d296184b..4fffd7007040 100644
> > --- a/drivers/staging/pi433/pi433_if.c
> > +++ b/drivers/staging/pi433/pi433_if.c
> > @@ -1409,11 +1409,11 @@ static int __init pi433_init(void)
> >   
> >   	status = spi_register_driver(&pi433_spi_driver);
> >   	if (status < 0)
> > -		goto unreg_class_and_remove_dbfs;
> > +		goto destroy_class_and_remove_dbfs;
> >   
> >   	return 0;
> >   
> > -unreg_class_and_remove_dbfs:
> > +destroy_class_and_remove_dbfs:
> >   	debugfs_remove(root_dir);
> >   	class_destroy(pi433_class);
>
> This is cleaning up something which changed in patch 1 so it should have
> been done in patch 1.
Thanks for your input.
I thought of a previous comment you had were you noted Greg preferred 
small patches, so I did my best to keep the first patch the with minimum 
changes without breaking git digest.

This patchset won't be accepted anyway.

> regards,
> dan carpenter
>
> >   unreg_chrdev:
> > --
> > 2.34.1
--
Regards,

Shahar