Re: [PATCH RFC v2 4/4] riscv: dts: thead: Add clock to TH1520 mmc controllers

From: Thomas Bonnefille
Date: Thu May 02 2024 - 03:48:25 EST




On 4/27/24 2:10 AM, Drew Fustini wrote:
Change the clock property in the T-Head TH1520 mmc controller nodes to a
real clock provided by the AP_SUBSYS clock driver.

Signed-off-by: Drew Fustini <dfustini@xxxxxxxxxxxxxxx>

I experienced that, when the I2C clocks were correctly configured, the UART stopped working, likely due to their dependence on FOUTPOSTDIV.
Setting up the UART correctly, for instance:

uartx: serial@xxxxxxxxxx {
...
clocks = <&clk CLK_UART_SCLK>, <&clk CLK_UARTX_PCLK>;
clock-names = "baudclk", "apb_pclk";
...
status = "disabled";
};
resolved the issue.
As this would be mandatory in the future, I suggest that you configure all the nodes currently set to a fixed clock, not just the MMC controller.

Thomas