Re: [PATCH] spmi: pmic-arb: Fix of_irq_get_byname() error checking

From: Stephen Boyd
Date: Wed May 01 2024 - 20:55:13 EST


Quoting Dan Carpenter (2024-04-24 04:42:46)
> There are two bugs in this code:
> 1) The "irq" variable needs to be signed for the error handling to
> work.
> 2) The of_irq_get_byname() also returns zero on error so change the
> comparison from < 0 to <= 0.
>
> Fixes: 932282f154ac ("spmi: pmic-arb: Register controller for bus instead of arbiter")

Sadly this isn't stable because I just send patches over email.

> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---

Applied to spmi-next