RE: [PATCH V2] firmware: arm_scmi: power_control: support suspend command

[Peng Fan]

> Subject: Re: [PATCH V2] firmware: arm_scmi: power_control: support
> suspend command
> 
> On Sun, Apr 28, 2024 at 03:51:05PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@xxxxxxx>
> >
> > Support System suspend notification. Using a work struct to call
> > pm_suspend. There is no way to pass suspend level to pm_suspend, so
> > use MEM as of now.
> >
> > - The choice of S2R(MEM) by default. The userspace can configure whatever
> >   default behaviour expected as S2R, if issuing suspend from userspace.
> >
> > - The userspace needs to keep the wakeup source enabled, otherwise the
> >   system may never resume back.
> >
> > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > ---
> 
> Have you tried triggering a suspend with this on your setup ?

Yes, this feature is already in NXP internal git tree and tested.

> 
> Anyway, LGTM.
> Reviewed-by: Cristian Marussi <cristian.marussi@xxxxxxx>
> 

Thanks,
Peng.
> Thanks,
> Cristian