Re: [PATCH] Revert "ext4: apply umask if ACL support is disabled"

From: Michael Forney
Date: Wed May 01 2024 - 16:04:49 EST


Michael Forney <mforney@xxxxxxxxxxx> wrote:
> Max Kellermann <max.kellermann@xxxxxxxxx> wrote:
> > This reverts commit 484fd6c1de13b336806a967908a927cc0356e312. The
> > commit caused a regression because now the umask was applied to
> > symlinks and the fix is unnecessary because the umask/O_TMPFILE bug
> > has been fixed somewhere else already.
>
> Thanks, Max! I've verified that this fixes symlink modes for me,
> as well as the flatpak corruption error I was getting.
>
> > Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforneyorg/
> > Signed-off-by: Max Kellermann <max.kellermann@xxxxxxxxx>
>
> Tested-by: Michael Forney <mforney@xxxxxxxxxxx>

Just checking in on this. I'd really like to see this regression
fixed. It currently affects versions 6.5 through 6.9-rc6 as well
as all longterm releases.