Re: [PATCH 07/10] writeback: factor out wb_dirty_freerun to remove more repeated freerun code

[Tejun Heo]

On Mon, Apr 29, 2024 at 11:47:35AM +0800, Kemeng Shi wrote:
..
> +static void wb_dirty_freerun(struct dirty_throttle_control *dtc,
> +			     bool strictlimit)
> +{
..
> +	/*
> +	 * LOCAL_THROTTLE tasks must not be throttled when below the per-wb
> +	 * freerun ceiling.
> +	 */
> +	if (!(current->flags & PF_LOCAL_THROTTLE))
> +		return;

Shouldn't this set free_run to true?

Also, wouldn't it be better if these functions return bool instead of
recording the result in dtc->freerun?

Thanks.

-- 
tejun