Re: [PATCH 0/7] sh: Fix missing prototypes (part two)

From: John Paul Adrian Glaubitz
Date: Wed May 01 2024 - 12:49:47 EST


Hi Geert,

On Mon, 2024-03-04 at 20:10 +0100, Geert Uytterhoeven wrote:
> Hi all,
>
> This patch series fixes more "no previous prototype for <foo>" warnings
> when building a kernel for SuperH, and is a follow-up to [1].
>
> This has been boot-tested on landisk and on qemu/rts7751r2d.
>
> Thanks for your comments!
>
> [1] "[PATCH 00/20] sh: Fix missing prototypes"
> https://lore.kernel.org/r/cover.1709326528.git.geert+renesas@xxxxxxxxx>
>
> Geert Uytterhoeven (7):
> sh: cache: Move forward declarations to <asm/cacheflush.h>
> sh: traps: Make is_dsp_inst() static
> sh: mach-highlander: Add missing #include <mach/highlander.h>
> sh: mach-sh03: Make sh03_rtc_settimeofday() static
> sh: sh7757lcr: Make init_sh7757lcr_IRQ() static
> sh: sh7757: Add missing #include <asm/mmzone.h>
> sh: sh7785lcr: Make init_sh7785lcr_IRQ() static
>
> arch/sh/boards/board-sh7757lcr.c | 2 +-
> arch/sh/boards/board-sh7785lcr.c | 2 +-
> arch/sh/boards/mach-highlander/pinmux-r7785rp.c | 1 +
> arch/sh/boards/mach-sh03/rtc.c | 2 +-
> arch/sh/include/asm/cacheflush.h | 12 ++++++++++++
> arch/sh/kernel/cpu/sh4a/setup-sh7723.c | 3 +++
> arch/sh/kernel/cpu/sh4a/setup-sh7724.c | 1 +
> arch/sh/kernel/cpu/sh4a/setup-sh7757.c | 3 +++
> arch/sh/kernel/traps_32.c | 4 ++--
> arch/sh/mm/cache-sh4.c | 2 --
> arch/sh/mm/cache-shx3.c | 1 +
> arch/sh/mm/cache.c | 14 --------------
> 12 files changed, 26 insertions(+), 21 deletions(-)

All patches look good to me, so for the whole series:

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913