Re: [PATCH] firewire: ohci: mask bus reset interrupts between ISR and bottom half

From: Adam Goldman
Date: Wed May 01 2024 - 07:39:41 EST


Hi Takashi,

On Mon, Apr 01, 2024 at 09:18:00PM +0900, Takashi Sakamoto wrote:
> I sent an additional patch[1] to handle the bus-reset event at the first
> time. I'd like you to review and test it as well, especially under your
> environment in which 1394:1995 and 1394a phys exist.
>
> [1] https://lore.kernel.org/lkml/20240401121200.220013-1-o-takashi@xxxxxxxxxxxxx/

I'm sorry for another very late reply.

Now that we eliminated the IRQ storm, it makes sense to always enable
the bus-reset interrupt at startup. I tested your patch with various
devices, with a FW800 repeater, with a FW400 hub, without a hub, etc.
Everything works OK. However, I only tested with XIO2213B OHCI.

-- Adam