Re: [PATCH v4 03/10] dt-bindings: test: Add KUnit empty node binding

[David Gow]

On Tue, 23 Apr 2024 at 07:24, Stephen Boyd <sboyd@xxxxxxxxxx> wrote:
>
> Describe a binding for an empty device node used by KUnit tests to
> confirm overlays load properly.
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
> Cc: Brendan Higgins <brendan.higgins@xxxxxxxxx>
> Cc: David Gow <davidgow@xxxxxxxxxx>
> Cc: Rae Moar <rmoar@xxxxxxxxxx>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxx>
> ---

Looks good to me.

Reviewed-by: David Gow <davidgow@xxxxxxxxxx>

-- David

>  .../devicetree/bindings/test/test,empty.yaml  | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/test/test,empty.yaml
>
> diff --git a/Documentation/devicetree/bindings/test/test,empty.yaml b/Documentation/devicetree/bindings/test/test,empty.yaml
> new file mode 100644
> index 000000000000..20dc83b15bbf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/test/test,empty.yaml
> @@ -0,0 +1,30 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/test/test,empty.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Empty node
> +
> +maintainers:
> +  - David Gow <davidgow@xxxxxxxxxx>
> +  - Brendan Higgins <brendanhiggins@xxxxxxxxxx>

Brendan: Do you want to use your linux.dev address here?


> +
> +description:
> +  An empty node to confirm tests can load device tree overlays.
> +
> +properties:
> +  compatible:
> +    const: test,empty
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    kunit-node {
> +      compatible = "test,empty";
> +    };
> +...
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature