Re: [PATCH] of: of_reserved_mem: clean-up reserved memory with no-map

From: kernel test robot
Date: Wed May 01 2024 - 01:00:17 EST


Hi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.9-rc6 next-20240430]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/skseofh-gmail-com/of-of_reserved_mem-clean-up-reserved-memory-with-no-map/20240430-144643
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20240428125505.434962-1-skseofh%40gmail.com
patch subject: [PATCH] of: of_reserved_mem: clean-up reserved memory with no-map
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240501/202405011208.qsZQwChO-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240501/202405011208.qsZQwChO-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405011208.qsZQwChO-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/of/of_reserved_mem.c:95:4: warning: non-void function 'early_init_dt_reserve_memory' should return a value [-Wreturn-type]
return;
^
1 warning generated.


vim +/early_init_dt_reserve_memory +95 drivers/of/of_reserved_mem.c

80
81 static int __init early_init_dt_reserve_memory(phys_addr_t base,
82 phys_addr_t size, bool nomap)
83 {
84 if (nomap) {
85 /*
86 * If the memory is already reserved (by another region), we
87 * should not allow it to be marked nomap, but don't worry
88 * if the region isn't memory as it won't be mapped.
89 */
90 if (memblock_overlaps_region(&memblock.memory, base, size) &&
91 memblock_is_region_reserved(base, size))
92 return -EBUSY;
93
94 if (memblock_mark_nomap(base, size))
> 95 return;
96 }
97 return memblock_reserve(base, size);
98 }
99

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki