Re: [PATCH] openrisc: Use do_kernel_power_off()

From: Stafford Horne
Date: Mon Apr 15 2024 - 10:22:41 EST


On Sun, Apr 14, 2024 at 07:52:03PM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Sun, Mar 31, 2024 at 08:02:28AM +0100, Stafford Horne wrote:
> > After commit 14c5678720bd ("power: reset: syscon-poweroff: Use
> > devm_register_sys_off_handler(POWER_OFF)") setting up of pm_power_off
> > was removed from the driver, this causes OpenRISC platforms using
> > syscon-poweroff to no longer shutdown.
> >
> > The kernel now supports chained power-off handlers. Use
> > do_kernel_power_off() that invokes chained power-off handlers. All
> > architectures have moved away from using pm_power_off except OpenRISC.
> >
> > This patch migrates openrisc to use do_kernel_power_off() instead of the
> > legacy pm_power_off().
> >
> > Fixes: 14c5678720bd ("power: reset: syscon-poweroff: Use devm_register_sys_off_handler(POWER_OFF)")
> > Signed-off-by: Stafford Horne <shorne@xxxxxxxxx>
> > ---
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>

Hello,

Thank you for the review.

-Stafford