Re: [GIT PULL] tracing: Fixes for v6.9

[Randy Dunlap]

On 4/12/24 9:15 AM, Steven Rostedt wrote:
> On Fri, 12 Apr 2024 09:07:18 -0700
> Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
>> On Fri, 12 Apr 2024 at 07:29, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>>>
>>> - Replace bad tab with space in Kconfig for FTRACE_RECORD_RECURSION_SIZE  
>>
>> Argh. What parser is this? We need to fix this craziness.

something that fedora cares about.
out-of-tree I expect.

>> Yes, yes, we have "tabs and spaces" issues due to the fundamental
>> brokenness of make, and we can't get rid of *that* bogosity.
>>
>> But for our own Kconfig files? Whitespace is whitespace (ignoring
>> crazy unicode extensions), we need to get away from "tabs and spaces
>> act differently".
> 
> Note, the tab is here:
> 
> -	default	128
> +	default 128
>                ^
> 
> That is, the tab was between "default" and "128".
> 
> I'm really agnostic to if we care about it, and was questioning about
> taking it or not. But, it looks to be a hidden tab in a weird location,
> so I took it.

Yes, I'm about the same. My comments were:

"""
> Fix FTRACE_RECORD_RECURSION_SIZE entry, replace tab with

replace the tab between "default" and "128" with a space

> a space character. It helps Kconfig parsers to read file
> without error.

Parsers should accept either tab or space but this is a
reasonable change.
"""

Guess I wasn't forceful enough.