Re: [PATCH v2 0/2] ACPICA: AEST: Support AEST V2

From: Ruidong Tian
Date: Thu Apr 11 2024 - 22:42:08 EST




在 2024/4/11 17:14, Sudeep Holla 写道:
On Thu, Apr 11, 2024 at 03:54:48PM +0800, Ruidong Tian wrote:


在 2024/4/10 17:22, Sudeep Holla 写道:
On Wed, Apr 10, 2024 at 02:36:00PM +0800, Ruidong Tian wrote:
AEST V2 was published[1], add V2 support based on AEST V1.


Any changes to ACPICA has to get merged in the external ACPICA project.
Refer [1] for details from Rafael. You can also refer [2] in the kernel
docs.


Patch1 is just a fix to follow kernel code style.

IIUC such changes are not allowed as ACPICA changes are always imported
from the external project. So you have to take same route as patch2

In ACPICA, all struct use typedef which is not allowed in kernel:

It's a **mistake** to use typedef for structures and pointers[1].

I see all other structs in actbl2.h follow this rule, so I fix all typedef in AEST struct to follow kernel code style. But i can not apple this fix in ACPICA. Patch1 is just a kernel patch.

[1]: Documentation/process/coding-style.rst

1
Patch2 had merged to
acpica project, PR link can be see in patch2 comment:

Link: https://github.com/acpica/acpica/commit/ebb4979

Thanks, this will then get imported into kernel next time ACPICA changes
get merged which usually happens regularly.