Re: [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string
From: Krzysztof Kozlowski
Date: Thu Apr 11 2024 - 04:14:03 EST
On 11/04/2024 09:43, Joy Zou wrote:
> The compatible string "fsl,imx8qm-adma" is unused.
Why? Commit must stand on its own.
>
> Signed-off-by: Joy Zou <joy.zou@xxxxxxx>
> ---
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
> Documentation/devicetree/bindings/dma/fsl,edma.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index 825f4715499e..64fa27d0cd9b 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -21,7 +21,6 @@ properties:
> - enum:
> - fsl,vf610-edma
> - fsl,imx7ulp-edma
> - - fsl,imx8qm-adma
I see more usages. One more trivial patch which is incorrect.
Did you implement the internal review?
Best regards,
Krzysztof