Re: [PATCH][next] fs/direct-io: remove redundant assignment to variable retval

[Jan Kara]

On Wed 10-04-24 17:22:21, Colin Ian King wrote:
> The variable retval is being assigned a value that is not being read,
> it is being re-assigned later on in the function. The assignment
> is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> fs/direct-io.c:1220:2: warning: Value stored to 'retval' is never
> read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Indeed it's assigned a few lines below. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/direct-io.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/direct-io.c b/fs/direct-io.c
> index 62c97ff9e852..b0aafe640fa4 100644
> --- a/fs/direct-io.c
> +++ b/fs/direct-io.c
> @@ -1217,7 +1217,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
>  	 */
>  	inode_dio_begin(inode);
>  
> -	retval = 0;
>  	sdio.blkbits = blkbits;
>  	sdio.blkfactor = i_blkbits - blkbits;
>  	sdio.block_in_file = offset >> blkbits;
> -- 
> 2.39.2
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR