Re: Re: [PATCH v4 1/2] dt-bindings: media: imx8-jpeg: Add clocks entries

From: Mirela Rabulea
Date: Mon Apr 08 2024 - 03:55:27 EST


Hi Krzysztof,

On 08.04.2024 09:38, Krzysztof Kozlowski wrote:
Please correct subject. You already got comments on this.
https://lore.kernel.org/linux-devicetree/2fb8c43c-c079-e04e-f727-3bc1dc29996e@xxxxxxxxxx/

Sorry I missed that.

I will update the prefix to "media: dt-bindings: nxp,imx8-jpeg:". as you suggested in v2.
Changes since v3:
- Add items for clocks (per Krzysztof's feddback)
- Add description for clocks (per Conor's feddback to the other similar patch from Alexander)
- Add "media:" to the subject
Where? It was there before, so what did you change?

I started from v3 here: https://lore.kernel.org/linux-devicetree/20230912163810.1750488-1-festevam@xxxxxxxxx/

The subject was: "[PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries", I had just added "media:". Anyways, will update it again.

+ clocks:
+ description:
+ The JPEG decoder/encoder requires two clocks for it's wrapper (AXI and APB),
+ and one clock for it's core engine (AXI, same source as for the wrapper)
Description is now redundant, drop it.

Ok, I will do so in v5.

Thanks a lot for feedback,

Mirela