Re: [PATCH v19 120/130] KVM: TDX: Add a method to ignore dirty logging

From: Edgecombe, Rick P
Date: Fri Mar 15 2024 - 10:02:05 EST


On Thu, 2024-03-14 at 18:35 -0700, Isaku Yamahata wrote:
> > On the subject of warnings and KVM_BUG_ON(), my feeling so far is
> > that
> > this series is quite aggressive about these. Is it due the
> > complexity
> > of the series? I think maybe we can remove some of the simple ones,
> > but
> > not sure if there was already some discussion on what level is
> > appropriate.
>
> KVM_BUG_ON() was helpful at the early stage.  Because we don't hit
> them
> recently, it's okay to remove them.  Will remove them.

Hmm. We probably need to do it case by case.