Re: [PATCH v3] i2c: i2c-qcom-geni: Parse Error correctly in i2c GSI mode

[Andi Shyti]

Hi Mukesh,

> > > +	status = FIELD_GET(I2C_DMA_TX_IRQ_MASK, i2c_res->status);
> > 
> > This fails here:
> > 
> > drivers/i2c/busses/i2c-qcom-geni.c: In function 'i2c_gpi_cb_result':
> > drivers/i2c/busses/i2c-qcom-geni.c:493:18: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
> >    493 |         status = FIELD_GET(I2C_DMA_TX_IRQ_MASK, i2c_res->status);
> >        |                  ^~~~~~~~~
> > cc1: all warnings being treated as errors
> > 
> > I will remove this patch from the i2c/i2c-host and we will need
> > to wait for the next merge window to get this through.
> > 
> > Please submit v4 with the Cc list recommended by Wolfram.
> > Submitted V4 patch. Let me wait for the dmaengine maintainers to sig off
> too. Sorry for the trouble.

Please, don't be sorry... when something goes wrong it's a shared
responsibility.

But fortunately nothing went really wrong here because Stephen
cought it in time :-)

I missed this failure because in the testing config the qcom-geni
was missing.

Thanks for the prompt fix!

Andi