Re: [PATCH v2] integrity: eliminate unnecessary "Problem loading X.509 certificate" msg

[Coiby Xu]

On Wed, Mar 06, 2024 at 01:40:01PM +0100, Maxime Ripard wrote:
> On Wed, Mar 06, 2024 at 06:55:00AM -0500, Mimi Zohar wrote:
> > On Wed, 2024-03-06 at 11:57 +0100, Maxime Ripard wrote:
> > > Hi Dmitry, Eric, James, Mimi, Paul, Serge,
> > >
> > > On Tue, Jan 09, 2024 at 08:24:28AM +0800, Coiby Xu wrote:
> > > > Currently when the kernel fails to add a cert to the .machine keyring,
> > > > it will throw an error immediately in the function integrity_add_key.
> > > >
> > > > Since the kernel will try adding to the .platform keyring next or throw
> > > > an error (in the caller of integrity_add_key i.e. add_to_machine_keyring),
> > > > so there is no need to throw an error immediately in integrity_add_key.
> > > >
> > > > Reported-by: itrymybest80@xxxxxxxxxxxxxx
> > > > Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2239331
> > > > Fixes: d19967764ba8 ("integrity: Introduce a Linux keyring called machine")
> > > > Reviewed-by: Eric Snowberg <eric.snowberg@xxxxxxxxxx>
> > > > Signed-off-by: Coiby Xu <coxu@xxxxxxxxxx>
> > >
> > > Any chance this patch can be merged? This is breaking (at least) Fedora
> > > at the moment.
> >
> > https://git.kernel.org/torvalds/c/29cd507cbec282e13dcf8f38072a100af96b2bb7
>
> Oh, awesome, we missed it.

Oh, I missed the emails about Mimi's PR sent to Linus as well. Btw, I'm
curious to ask why you used the word "breaking" because I thought these KERN_ERR
errors shouldn't cause any real problem.

--
Best regards,
Coiby