Re: [PATCH] drivers/gpio/nomadik: move dummy nmk_gpio_dbg_show_one() to header

[Linus Walleij]

On Mon, Mar 11, 2024 at 2:32 PM Max Kellermann <max.kellermann@xxxxxxxxx> wrote:

> When `CONFIG_DEBUG_FS` is disabled, nmk_gpio_dbg_show_one() is an
> empty dummy function; this however triggers a `-Wmissing-prototypes`
> warning and later a linker error because the function is also used by
> drivers/pinctrl/nomadik/pinctrl-nomadik.c, therefore it needs to be
> non-static.
>
> To allow both sources to access this dummy function, this patch moves
> it to the header, adding the `#ifdef CONFIG_DEBUG_FS` there as well.
>
> Signed-off-by: Max Kellermann <max.kellermann@xxxxxxxxx>

I made a patch myself yesterday and applied, but I like your patch more
so I took out my patch and put in yours instead.

Thanks!

Yours,
Linus Walleij