Re: [PATCH 3/3] auxdisplay: img-ascii-lcd: Convert to platform remove callback returning void

[Uwe Kleine-König]

On Tue, Mar 12, 2024 at 09:17:54AM +0100, Geert Uytterhoeven wrote:
> Hi Uwe,
> 
> On Mon, Mar 11, 2024 at 10:59 PM Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> >
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> >
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/drivers/auxdisplay/img-ascii-lcd.c
> > +++ b/drivers/auxdisplay/img-ascii-lcd.c
> > @@ -279,13 +279,12 @@ static int img_ascii_lcd_probe(struct platform_device *pdev)
> >   *
> >   * Return: 0
> 
> Please remove this line.

Good catch, thanks.

@Andy: Should I resend this patch? Or the whole series? Or do you want
to fixup while applying?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature