Re: [PATCH 2/4] perf vendor events amd: Add Zen 5 uncore events

From: Ian Rogers
Date: Mon Mar 11 2024 - 13:44:12 EST


On Sun, Mar 10, 2024 at 10:24 PM Sandipan Das <sandipan.das@xxxxxxx> wrote:
>
> Add uncore events taken from Section 1.5 "L3 Cache Performance Monitor
> Counters" and Section 2 "UMC Performance Monitors" of the Performance
> Monitor Counters for AMD Family 1Ah Model 00h-0Fh Processors document
> available at the link below. This constitutes events which capture L3
> cache and UMC command activity.

Why do the L3 uncore PMU events go in the same topic as the core/cpu
events, but the memory controller events not? Could they both go in
separate files to make better use of the topic?

Thanks,
Ian

> Link: https://bugzilla.kernel.org/attachment.cgi?id=305974
> Signed-off-by: Sandipan Das <sandipan.das@xxxxxxx>
> ---
> .../pmu-events/arch/x86/amdzen5/cache.json | 175 ++++++++++++++++++
> .../arch/x86/amdzen5/memory-controller.json | 101 ++++++++++

[ ... snip ... ]