Re: [RESEND PATCH v2] x86/apic: Use u32 instead of unsigned long
From: Dave Hansen
Date: Fri Mar 08 2024 - 11:13:09 EST
On 3/8/24 04:43, Thorsten Blum wrote:
> Improve types by using u32 instead of unsigned long. Fixes two
> Coccinelle/coccicheck warnings reported by do_div.cocci.
This seems simple enough, but the changelog and subject are really
lacking in substantive information.
The _patch_ literally does a few s/unsigned long/u32/ operations, and
that's just repeated pretty much verbatim in the changelog and subject.
So it just tells me two more times what I already know.
Without going and running do_div.cocci I can't tell whether the warnings
are good checks or nonsense. I also don't know _which_ do_div()s the
warnings even refer to.
Could we get a _little_ more meat in here, please?